[bug] Fix crash when using custom java object in python async thread#95
Open
bgeng777 wants to merge 1 commit intoalibaba:release-0.5from
Open
[bug] Fix crash when using custom java object in python async thread#95bgeng777 wants to merge 1 commit intoalibaba:release-0.5from
bgeng777 wants to merge 1 commit intoalibaba:release-0.5from
Conversation
|
pemja/src/main/c/pemja/core/pylib.c Line 191 in 2c84a2f I tested this patch locally and found that an exception is thrown first when JcpThread is NULL. After commenting out this logic, it appears to work. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #93 . When a Java object is passed from a pemja thread to a Python async thread, calling a
method that returns a custom Java object crashes the JVM with SIGSEGV. Methods
returning built-in types (String, List, etc.) work normally.
Cause
pyjobject_init(pyjobject.c) callsJcpThread_Get()to access the per-threadattribute cache. On non-pemja threads, this returns NULL — which is immediately
dereferenced without a NULL check:
Built-in types bypass this path — they have dedicated converters in
JcpPyObject_FromJObjectthat never callJcpThread_Get(). Only custom objects,Collection, Iterable, and Iterator go through
JcpPyJObject_New→pyjobject_init.Fix
File:
src/main/c/pemja/core/python_class/pyjobject.cWhen
JcpThread_Get()returns NULL, clear the Python error and skip the per-threadcache — build the attrs dict directly and manage reference counts without the cache.
JNI reflection (no cache).